Review of "Passwordstore Manager" version 2

Details Page Preview

Access your passwords from pass (passwordstore.org) from the GNOME Shell.

Extension Homepage
https://github.com/dmzoneill/pass-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. As mentioned before, you should remove the timeout on destroy (line 66 `extension.js`). and you should remove it before creating a new one since that function can be called multiple times. As we mentioned in the review guidelines: > Note that all sources MUST be removed in disable(), > even if the callback function will eventually return false > or GLib.SOURCE_REMOVE. 2. You removed the schemas xml file while you are using it in your extension. 3. Don't use `Gio.Settings` for the extension settings (line 178 `extension.js`). You have `this.getSettings()` in the entry point: [Port Guide 45: getSettings](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 4. Move line 186 `extension.js` outside of that if condition. 5. The `prefs.js` sets `example-key` but you are not using it on `extension.js`. So, if the `prefs.js` is just a bad upload, remove the `prefs.js` and `getSettings()` from `extension.js`. Also, remove the `settings-schema` from `metadata.json` if that's the case.