1. Really not needed (line 228 `prefs.js`). 2. Please remove `preferences` and `extension.js` from `metadata.json`. Not needed. 3. Remove line 12-14 `extension.js`. You should simply do `ExtensionUtils.initTranslations()` in `init()`: [Legacy Translations](https://gjs.guide/extensions/upgrading/legacy-documentation.html#complete-example) 4. You cannot create instance of an object in the constructor (line 709 `extension.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 6. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 7. Timeout should be removed on disable (line 751 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 8. You shouldn't really create the settings instance again (line 128 `extension.js`). Just pass it from the entry point to the indicator class. 9. You should `abort()` the session on destroy (line 228 `extension.js`): [Soup.Session.abort()](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 10. Please add to the description that this extension is using `godville.net` services. 11. Don't use spawn commands to open URLs. Use this instead: ```js Gio.AppInfo.launch_default_for_uri(URL, null); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions