Review of "axet's System Monitor" version 2

Details Page Preview

Fork of GNOME system-monitor extension. Compact view. # Installation Required system dependencies: * sudo apt install gir1.2-gtop-2.0 * sudo yum install libgtop2 * sudo pacman -S libgtop CPU wattage support: * sudo apt install sysfsutils ``` /etc/sysfs.conf mode class/powercap/intel-rapl:0/energy_uj = 0444 mode class/powercap/intel-rapl:0:0/energy_uj = 0444 ``` CPU Fans Edit options.js file with correct CPU Fan driver name or label. Other customization: Edit options.js file.

Extension Homepage
https://gitlab.com/axet/gnome-shell-extension-system-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Active
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please follow the rules for schemas: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas Also, you didn't change the schemas as requested before. 2. #3 from previous review hasn't been addressed here.
axet posted a review
Original code from google system-monitor has no implict destory() call. So I have no idea where to call it. I'm not shell extension developer, just did simple patching. https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/main/extensions/system-monitor/extension.js?ref_type=heads
JustPerfection posted a review
Inside `Indicator`: ```js destroy() { this._cpuSection?.destroy(); this._memSection?.destroy(); this._swapSection?.destroy(); this._netSection?.destroy(); super.destroy(); } ``` btw, if this is a fork, you need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed)