Review of "ULauncher Toggle" version 1

Details Page Preview

A GNOME extension to toggle the ULauncher service on/off from the quick settings menu

Extension Homepage
https://github.com/ghostdevv/ulauncher-toggle-gnome-shell-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
1. Please remove `settings-schema` from `metadata.json` since you are not using it. 2. Isn't Ulauncher exposing the feature that you can use it in d-bus instead of spawn command? [GJS Guide: D-Bus](https://gjs.guide/guides/gio/dbus.html) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
onlyspaceghost posted a review
> 1. Please remove `settings-schema` from `metadata.json` since you are not using it. Ah ty! Copied the boilerplate from another extension and didn't notice that to remove > 2. Isn't Ulauncher exposing the feature that you can use it in d-bus instead of spawn command? Not to my knowledge, but I don't know a lot about dbus. It's default setup is a systemd user service, and so I just kept that behaviour when starting/stopping it.
JustPerfection posted a review
Ok. just make sure the description says "toggle ULauncher service" instead of "toggle ULauncher" (`ulauncher-toggle`) so it's not confusing for users.
onlyspaceghost posted a review
> Ok. just make sure the description says "toggle ULauncher service" instead of "toggle ULauncher" (`ulauncher-toggle`) so it's not confusing for users. What about "toggle" is confusing? /genq
JustPerfection posted a review
When I opened the review and read the extension name, I thought this extension is simply going to do `ulauncher-toggle` via spawn command or dbus.
onlyspaceghost posted a review
> When I opened the review and read the extension name, I thought this extension is simply going to do `ulauncher-toggle` via spawn command or dbus. Ahh fair enough - WDYT about renaming to `ulauncher-switch`? Or is that also ambiguous? If so can do `ulauncher-service-toggle`!
JustPerfection posted a review
Adding this to the description would be enough: > This extension is toggling the ULauncher service status.
onlyspaceghost auto- rejected
Auto-rejected because of new version 2 was uploaded