Automatically mount bookmarked network locations with advanced configuration options and allows for creating symlinks for easy access from your homer directory
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
2 | Active |
1 | Rejected |
Hi and thanks for reviewing. To address the points you raised, I will refer you to the relevant Git commits for each: 1. Timeout should be removed on destroy (line 61, 67, 567, 623, 740 `extension.js`). [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) Fixed in: https://github.com/gavindi/network-share-automount/commit/d18574b2b7c173856aab2d719bd64fe58e7b2438 2. Please use `this.openPreferences()` from the entry point instead of spawn command (line 752 `extension.js`): [Extensions Guide: Extension](https://gjs.guide/extensions/topics/extension.html#methods-2) Fixed in: https://github.com/gavindi/network-share-automount/commit/a215962a1f44a981b3a5858bb62910c542b874d6 3. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) Fixed in: https://github.com/gavindi/network-share-automount/commit/a215962a1f44a981b3a5858bb62910c542b874d6 and https://github.com/gavindi/network-share-automount/commit/33f5524db3636f1221d0696db90d6c7c5b42403d 4. Please don't store any instance of objects in a property in the default class you are exporting in `prefs.js`. that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Fixed in: https://github.com/gavindi/network-share-automount/commit/288607a4e56c4eea96fb95c9df241d713d3fcad2