Review of "Monitor DDC Brightness/Contrast" version 1

Details Page Preview

Control Monitor brightness and contrast with ddcutil. **ddcutil must be installed** For more details, refer to the GitHub project's documentation page. This fork (from tzawezin's project - https://github.com/tzawezin/gnome-ddc-brightness-contrast-extra-dimming) was created to remove the extra Dim slider, change icons, and improve the overall visual appearance.

Extension Homepage
https://github.com/leoleguizamon97/gnome-ddc-brightness-contrast

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. No need to use `this.initTranslation()` (line 211 `extension.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. `paypal` should be user handle not URL. 3. This is not 45+ compatible: [Port Guide 45: ESM](https://gjs.guide/extensions/upgrading/gnome-shell-42.html#esm) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
leoleguizamon97 posted a review
Hi, thank you for your review. I've already made the required changes, but I had some doubts about the `ExtensionUtils.initTranslations` function, so I just removed it along with related code. The compatible versions were taken from the fork, I assume the compatibility will be the same. I'm really new to GNOME extensions (and this is just a fork), so I truly appreciate any feedback you can give. When I have more free time, I'll study the GNOME project more thoroughly. P.S.: English isn't my native language, so please excuse any mistakes.