Review of "Currency Conversion Rate" version 1

Details Page Preview

Displays real-time currency conversion rates on the GNOME top panel

Extension Homepage
https://github.com/binary-smith/currency-conversion-rate

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

Binary Smith posted a review
JustPerfection rejected
1. Why not just including the file in the extension package (line 42 `prefs.js`)? Is it getting changed frequently? 2. Please don't create instance of objects in global scope (line 6 `convenience.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Remove version from the import since that is already specified by GNOME Shell (line 3 `convenience.js`). 4. You should call `abort()` on disable or destroy (line 6 `convenience.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 5. Please remove the `getSettings()` function (line 13-41 `convenience.js`). You already have `this.getSettings()` in the entry point. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions