Review of "Gnoming Profiles" version 1

Details Page Preview

Sync gsettings and user config files to GitHub with binary-safe wallpaper syncing and ETag-based polling for ultra-efficient bandwidth usage

Extension Homepage
https://github.com/gavindi/gnoming-profiles

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. For GNOME Shell 45 you should include the schemas compiled file. Since 46 the compiled file not needed. 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. You should call `abort()` on disable or cleanup (line 24 `lib/GitHubAPI.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 4. Timeout should be removed on destroy: - line 265 `lib/SyncManager.js` - line 92, 117, 280 `lib/Utils.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
gavindi posted a review
Updated with the following fixes: 1. For GNOME Shell 45 you should include the schemas compiled file. Since 46 the compiled file not needed. Fixed: Removed support for Gnome 45: https://github.com/gavindi/gnoming-profiles/commit/ab16eb7291d3dbcedf4fa953ca47cfc95710f683 2. Use `console.*` instead of `log()` Fixed: modified to use console.* methods instead of log(): https://github.com/gavindi/gnoming-profiles/commit/e099e30a1c0636e7d43c6679e6e994326a78a69d 3. You should call `abort()` on disable or cleanup (line 24 `lib/GitHubAPI.js`) Fixed: HTTP Session Cleanup: https://github.com/gavindi/gnoming-profiles/commit/019257423bdac6969b808e3526168e0ca8f6e582 4: Timeout should be removed on destroy Fixed: FIXED: Timeout Management: https://github.com/gavindi/gnoming-profiles/commit/4ef04c91389e649ac1632e3c921c4ae85021af69 Thanks for you help and keep up the good work!! :)
JustPerfection posted a review
Thanks!