Periodically saves window positions and restores them on unlock. Fixes problem with windows getting moved around after monitor wake from screen lock on wayland.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
1. What's the reason for doing line 15 and 68 `extension.js`? You are already in the shell process, so you don't need to do that. 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Please remove everything you are doing in the constructor that breaks multiple rules (line 32-60 `extension.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Also, storing in meta is not a good practice. You already have `this`. 4. Please don't use deprecated modules (line 77 and 230 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 5. Remove unnecessary try and catch blocks. Shell should be able to catch the errors if there is any. So you can debug it later. 6. Use aysnc for reading file content since you are in shell process (line 228 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 7. Timeout should be removed before creating a new one since that function can be called multiple times (line 96, 121 `extension.js`). 8. Timeout should be removed on disable and before creating a new one (line 127 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 9. Remove unnecessary `main` from `metadata.json`. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Thanks for the detailed feedback! I've tried to address all these issues and uploaded a new version just now window-pinner@dhharker.net-7.zip.
Ok I just re-uploaded the file as it wasn't showing up on the list of uploads. It's version '3'. Sorry for confusion.