Review of "Simple Tiling" version 3

Details Page Preview

A Simple Tiling Extension for Gnome Shell.

Extension Homepage
https://github.com/Domoel/Simple-Tiling

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Active
12 Rejected
11 Inactive
10 Rejected
9 Rejected
8 Rejected
7 Inactive
6 Rejected
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Domoel posted a review
Thank you for the previous reviews. I have fixed the schema path issue and the timeout cleanup as requested. Regarding the deprecated ByteArray module: I have reverted to using it for now, because the modern alternative (TextDecoder) is not available in GNOME 3.38, which this version of the extension still supports. I will switch to TextDecoder once support for older GNOME versions is dropped in a future release.
JustPerfection rejected
#3 from version 1 review hasn't been addressed here.
JustPerfection posted a review
I didn't reject your extension for `ByteArray` since this is 3.38. As mentioned on version 1 review, `Mainloop` shouldn't be used there. Use [GLib.timeout_add`](https://gjs-docs.gnome.org/glib20~2.0/glib.timeout_add) instead.