Review of "Show My IP" version 1

Details Page Preview

Displays your local and public IP addresses in the top bar. Public IP is fetched using ifconfig.me.

Extension Homepage
https://github.com/juliansantosinfo/gnome-shell-extension-show-my-ip

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `settings-schema`, `icon`, `tags` and `contributors` from `metadata.json`. Not needed. 2. Remove `icons/icon.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 3. Add to the description that this extension is using `ifconfig.me` services. 4. Also null out in disable: ```js this._label?.destroy(); this._label = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 5. Don't use sync spawn since that can freeze the shell process (line 83 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 6. Please remove unnecessary function (line 116 `extension.js`). 7. Please don't use deprecated modules (line 27 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions