Review of "GNOME Window Rules" version 2

Details Page Preview

Makes windows matching user-defined titles sticky (on all workspaces), always-on-top, or both.

Extension Homepage
https://github.com/graham00/gnome-shell-extension-gnome-window-rules

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

graham00 posted a review
Okay, switched things around a lot with a lot - it's using weakmap now. Hopefully this does a better job with garbage collection and I don't waste anyone's time. I'm definitely in over my head with this! Still, I needed some way to make windows always-on-top automatically for work stuff, so I'm just trying to blunder my way through, and figured I'd share if it's not too much of a disaster, in case it's useful to someone else. If I need to change anything else just let me know. Appreciate it!
JustPerfection rejected
No worries, we are here to help. Just fix these issues and send it again: 1. Timeout should be removed on disable and also before creating a new timeout (line 130 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. As mentioned before, please cleanup on window close request (line 11 `prefs.js`): ```js window.connect('close-request', () => { this.settings = null; }); ```