Review of "Systemd Offline Update Indicator" version 48.12 (13)

Details Page Preview

Show an indicator for pending systemd offline updates.

Extension Homepage
https://codeberg.org/swsnr/gnome-shell-extension-systemd-offline-update

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
48.13 (14) Active
48.12 (13) Rejected
48.11 (12) Active
48.10 (11) Inactive
48.9 (10) Inactive
48.8 (9) Inactive
48.7 (8) Inactive
48.6 (7) Inactive
48.5 (6) Inactive
48.4 (5) Inactive
48.3 (4) Rejected
48.2 (3) Inactive
48.1 (2) Inactive
48.0 (1) Inactive

Previous Reviews on this Version

JustPerfection rejected
Timeout should be removed on destroy or disable (line 73 `extension.js`).
Sebastian Wiesner posted a review
That wouldn't make much of a difference would it? The extension would have to be disabled in the three-second window between setting up the timeout and it triggering, and even then it's a no-op unless the system is actually in power save mode, and then cancelling the update is probably desired anyway.
JustPerfection posted a review
All timeouts should be removed on disable: [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
Sebastian Wiesner posted a review
I see. I'll try to remember this for the next release.
Sebastian Wiesner posted a review
I see. I'll try to remember this for the next release.