1. Bad xml filename: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 2. Please remove `repository` and `homepage` from `metadata.json`. Not needed. 3. Move line 286-289 `extension.js` to the `HotspotToggle.destroy()`. At the end of that function simply do `super.destroy()`. 4. It shouldn't exist. Always should be destroyed on disable (line 261 `extension.js`). So remove line 261-275. 5. Shouldn't be a global variable (line 14 `extension.js`). Move it to the `HotspotExtension`. 6. Call `this._indicator.destroy()` before line 294 `extension.js`: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 7. Better to move to the `constructor()` instead of `_init()` since the language supports it (line 19 `extension.js`). 8. Don't use sync spawn since that can freeze the shell process (line 45, 64, 218, 220, 233 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 9. Timeout should be removed on destroy and before creating a new one since that function can be called multiple times (line 155, 219 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions