Review of "Avatar" version 29

Details Page Preview

Add Avatar and Top image into the panel. * Avatar (horizontal/vertical, shades, visibility of username and hostname) * Primary buttons * Top image (can be Your own image from system

Extension Homepage
https://github.com/pawelswiszcz/Avatar-Gnome-Shell-Extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
32 Active
31 Active
30 Rejected
29 Rejected
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Better to use `SessionManager` for that (line 174, 178 `src/UserWidget.js`): [`gnomeSession.SessionManager`](https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/gnomeSession.js) 2. Extensions cannot use `run_dispose()` (line 385 `src/UserWidget.js`): [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject) 3. `lookupByURL()` is a bad practice (line 392 `src/UserWidget.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions