Review of "CGM panel widget" version 1

Details Page Preview

CGM glucose monitor with real-time display and historical graph

Extension Homepage
https://github.com/bramgn/gnome-cgm-panel

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Inactive
7 Inactive
6 Rejected
5 Rejected
4 Inactive
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove unnecessary files: - `.github/FUNDING.yml` - `screenshots/popup.png` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Avoid using unnecessary try catch block. Especially in enable and disable. 3. You should setting any flag for destroy. Just simply call `destroy()` (line 715 `extension.js`). 4. Use dependency injection instead of line 701 `extension.js`. 5. Unnecessary import (line 8 `extension.js`). 6. Timeout should be removed on destroy and before creating a new one (line 267, 327, 339, 385, 398 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 7. You cannot import `Gdk` to the GNOME Shell process (line 20 `cgmGraph.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 8. Please don't store any instance of objects in a property in the default class you are exporting in `prefs.js`. That won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Either make them local to `fillPreferencesWindow()` function or clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 9. Is this a fork? If so, you need to mention it in the description. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
bramgn posted a review
Hi, Thank you for your time reviewing the CGM Gnome extension. I have made the requested changes as best I could. As to your question whether this is a fork; no, this is entirely a new extension, however, I did rely on LLMs (Claude Sonnet 4, Gemini) to help build and structure. Perhaps this might give the impression that the code has been used before. If you want to test this extension, I can provide a working API endpoint that can be used to display CGM values. Do I upload the updated version as a new one? Kind regards, Bram Groot Nuelend
JustPerfection posted a review
Yes, please upload the fixed version the same way you've sent this one.