Review of "USD to RUB Exchange Rate" version 6

Details Page Preview

Shows the current USD to RUB exchange rate on the GNOME panel

Extension Homepage
https://github.com/makev1ch/usd-rub

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
11 Active
10 Inactive
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please `stylesheet` from `metadata.json`. Not needed. 2. Remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 3. Remove unnecessary: - lines 18-47 `prefs.js` - line 25-61 `extension.js` 4. Remove version from import (line 6 `extension.js`). 5. Also call `label.destroy()` on disable. 6. You should call `abort()` on disable or destroy (line 97 `extension.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 7. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging)