Review of "Keylightd Control" version 4

Details Page Preview

Control keylightd via the GNOME Shell Quick Settings menu.

Extension Homepage
https://github.com/jmylchreest/keylightd

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging)
jmylchreest posted a review
hello, thanks for the feedback. log() is actually an imported util wrapper which allows for runtime filtering of console.*() logging, it isnt actually the old log() function (but it was historically). Would it be sufficient if I renamed the import so I can retain the configurable logging? The alternative is I pull out the settings based log filtering I think?
JustPerfection posted a review
Hi, not needed then. If it can be renamed to something else to make the review process easier would be better but not really needed.