Review of "ShaderPaper - Shader Wallpaper" version 1.6.2 (7)

Details Page Preview

Simple Shader Wallpaper for Gnome Shell Shader's from shadertoy.com can be applied from extension's preferences, currently supports only iTime, iResolution, iChannel0-3 uniforms - Applies shaders to: - Monitor backgrounds only. - Lockscreen only. - Apply on all backgrounds. - Live GLSL Shader Editor on Preferences - Texture supports Image - Sound Texture Support from GS 47 (performace improved) - Added rounded corners Notes: - Performance may vary depending of your specs, but it's actually not all that resource intensive, depends on the shader too. For any issues,bugs and suggestions plz open an issue on Gitlab _______________________________________________________________ For error like `Error: Requiring GtkSource, version none: Requiring namespace 'Gtk' version '3.0', but '4.0' is already loaded` on preferences please install libgtksourceview-5

Extension Homepage
https://gitlab.com/raihan2000/shaderpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.6.9 (9) Active
1.6.5 (8) Rejected
1.6.2 (7) Rejected
1.6 (6) Rejected
1.5 (5) Inactive
1.4 (4) Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You shouldn't disable and re-enable other extensions from your own extension (line 31 `extension.js`).
raihan2000 posted a review
okay, can you give me any other way to do this type of operations, cuz when blur-my-shell has already enabled it needs to re-enabled otherwise bms will not take the effects applies on backgrounds
JustPerfection posted a review
The main issue is that, on lock, your extension is going to change the GNOME Shell re-base process. Inside `refreshExtension()` check for session. If it is `user` then you can refresh. return otherwise. Also, the signal on line 59 `extension.js` should be disconnected on disable.
raihan2000 posted a review
sorry for late reply, the signal on line 59 created, also i'm disconnecting on line 62, do I need to do it on disable? cuz I need this signalId only for startup when startup finished it will automatically get disconnected. and Thanks for the review
JustPerfection posted a review
Yes, it should be disconnected on disable.