Review of "CryptoStash" version 6

Details Page Preview

Keep an eye on the real time value of your crypto coins collections. You can create multiple "stashes" (portfolios) of coins and monitor the accumulated value in USD or EUR. Or if you prefer, you can simply track the current value of your favorite coin. This extension uses the cryptostash.filidorwiese.nl to fetch cryptocurrency rates.

Extension Homepage
https://github.com/filidorwiese/gnome-shell-crypto-stash

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
10 Active
9 Rejected
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Active
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. Don't call functions in global scope (line 30 `HTTP.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. You should call `abort()` on disable or destroy (line 30 `HTTP.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 3. Deprecated modules still getting used: - line 1, 3 `IndicatorModel.js` - line 1 `StashModel.js` - line 1, 3 `CryptoRatesApi.js` 4. Remove `convenience.js`. You already have `ExtensionUtils.getSettings()`. 5. Remove line 39-61 `extensison.js`. Not needed. 6. Remove line 51-59, 80-87 `prefs.js` and import on top of the file.