Review of "Keyboard Modifiers Status" version 25

Details Page Preview

Shows keyboard modifiers status. It's useful when sticky keys are active.

Extension Homepage
https://github.com/sneetsher/Keyboard-Modifiers-Status

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `gschemas.compiled`. 45+ extension don't need it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Put the xml file into the `schemas` folder: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 3. Not needed (line 361-363 `prefs.js`). 4. Please don't store any instance of objects in a property in the default class you are exporting in `prefs.js`. That won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make them local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 5. Remove unnecessary import (line 22 `extension.js`). 6. Remove unnecessary line 36-44 `extension.js`. 7. What line 114-120 `extension.js` trying to do? `global.stage.context.get_backend().get_default_seat()`?
KMS posted a review
For 7. What line 114-120 `extension.js` trying to do? `global.stage.context.get_backend().get_default_seat()`? This extension is to support Xorg/Wayland sessions so it checks for Seat object then keyboard device object. Later, use keyboard device object to get keyboard modifier state and listen to its change event.