Review of "Phases of Moon" version 1

Details Page Preview

Display current moon phase

Extension Homepage
https://github.com/melomane63/phases-of-moon

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Move to enable and null out in disable (line 33-35 `extension.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. No needed (line 615-622 `extension.js`). You already have `this.path`. 4. What's the reason for saving (line 625-626 `extension.js`)? You can directly use the file in the extension directory. 5. Remove the timeout before creating a new one (line 866 `extension.js`). 6. Avoid unnecessary try and catch blocks. For example, in line 1080 `extension.js`, you can simply do this instead: ```js if (this._updateInterval) { GLib.Source.remove(this._updateInterval); this._updateInterval = null; } ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions