Review of "Save My Windows" version 4

Details Page Preview

Save My Windows periodically records all open windows along with their monitors and workspaces. It lets you restore your window layout whenever Wayland resets or scrambles positions (e.g. after suspend).

Extension Homepage
https://github.com/lukastymo/save-my-windows

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please use aysnc for reading file content since you are in shell process (line 25 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 2. Timeout should be removed on disable and before creating a new one (line 136, 151, 163, 282, 288 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging)