Review of "Gemoji — GNOME Emoji Picker" version 1

Details Page Preview

Quickly find and insert emojis from a compact GNOME Shell picker. Uses clipboard to copy emojis.

Extension Homepage
https://github.com/IshuSinghSE/gnome-emoji-picker

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Ishu posted a review
please review it and tell me, if any changes are needed!
JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Remove `schemas/org.gnome.shell.extensions.emoji-picker.gschema.xml`. Not needed. 3. Please remove unnecessary files and folders: - `.gitignore` - `assets` - `deploy.sh` - `docs` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 4. Remove line 47-49 `prefs.js`. Not needed. 5. Unused import (line 11 `extension.js`). 6. bad indentation (line 284-286, 347-350 `extension.js`). 7. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 8. Timeout should be removed on destroy and before creating a new one: - line 66, 200, 223 `core/categoryManager.js` - line 51 `core/clipboardManager.js` - line 90 `core/usageTracker.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) Also, don't forget to call `.destroy()` on the instances in `extension.js` or any other files. 9. Need to mention in the description that this extension is using clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 10. Remove line 69-85 `core/clipboardManager.js`. You shouldn't use spawn command for paste. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions