Review of "VLAN controller" version 1

Details Page Preview

Activate and deactivate VLAN connections from the top panel.

Extension Homepage
https://github.com/tiagocasalribeiro/gnome-vlan-controller

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Which one should be reviewed? This one or the [other](https://extensions.gnome.org/review/66130)?
tiagocasalribeiro posted a review
this one
JustPerfection rejected
1. Please don't use deprecated modules (line 73, 75, 78, 182 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 2. No need to use `this.initTranslation()` (line 198 `extension.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 3. Please look at how the gettext is getting imported (line 14 `extension.js`): [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 4. Remove 3.36-42 from `metadata.json` since this package is not compatible with those versions. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions