Review of "Vicinae" version 1.5.2 (5)

Details Page Preview

Companion GNOME extension for Vicinae launcher with clipboard monitoring, window management APIs, and paste-to-active-window capabilities.

Extension Homepage
https://github.com/dagimg-dot/vicinae-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.5.3 (6) Active
1.5.2 (5) Rejected
1.5.1 (4) Rejected
1.5.0 (3) Rejected
1.4.0 (2) Rejected
1.3.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Better to avoid unnecessary try and catch blocks. For example, you don't need to wrap it in line 28, 66-72 `extension.js`. Same for disable. Since it doesn't make the code less readable, it's just a recommendation for now. 2. Timeout should be removed on destroy and also before creating a new one since that function can be called multiple times: - line 417 `core/clipboard/clipboard-manager.js` - line 144, 163 `core/launcher/launcher-manager.js` - line 275 `core/windows/window-manager.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)