Review of "Matugen Auto-Themer" version 1

Details Page Preview

Generates GTK and Qt themes from your wallpaper using Matugen.

Extension Homepage
https://github.com/luxingzhi27/matugen-autothemer-for-gnome-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Better to use `close-request` signal for cleanup instead (line 121 `prefs.js`). 4. Remove `this._isRunning` from the default class you are exporting. That's a bad practice. Your extension is either enabled or disabled. 5. You should use gsettings for that (line 214 and 220 `extension.js`). 6. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 7. You want a local template file to use remote import (line 10 `matugen/templates/vesktop.css`)? 8. Fix indentation issues on `extension.js`. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions