Review of "Live Radio" version 1

Details Page Preview

Listen to live radio stations directly from the GNOME Shell panel - JSON configuration for easy editing of radio lists - Support for radio icons - Lightweight and easy to use - Stop/Mute buttons - Scroll volume control

Extension Homepage
https://github.com/dmachard/gnome-shell-extension-liveradio

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Unreviewed
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Please remove unnecessary try and catch wrapper (line 14 `extension.js`). 3. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
dmachard posted a review
Hi, Hi, Thanks for the review! I’ve made the following changes as requested: - Removed schemas/gschemas.compiled from the package. - Removed the unnecessary try/catch block in extension.js. - Updated all logging to use console.* methods (console.debug(), console.error(), etc.) according to the GNOME 45 Porting Guide. Everything should now comply with the GNOME 45+ guidelines. Thanks again for the feedback!