1. Unused import (line 2 `prefs.js`). 2. Creating many instances of gsettings with `extension.getSettings()` is not a good idea. Better to use the `extension.settings` instead. Same applies for `extension.getLogger()`. 3. Creating an instance of a class as static is the same as the extension constructor which breaks multiple rules (line 5-41 `lib/common/icons.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. You should call `abort()` on disable (line 20, 162 `lib/misc/link.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 5. Timeout should be removed on disable/destroy and before creating a new one: - line 62, 111 `lib/misc/gda.js` - line 195 `lib/ui/components/actionMenu.js` - line 311 `lib/ui/components/contentInfo.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 6. What's the reason for using `version` in the import (line 6 `lib/preferences/dependencies/dependencies.js`)? Asking that since GNOME Shell 45+ already using Soup 3. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions