Review of "Appearance Keeper" version 6

Details Page Preview

Automatically saves and restores accents, GTK, shell theme, icons, cursors themes for light and dark modes. shortcut to toggle mode

Extension Homepage
https://github.com/melomane63/Appearance-Keeper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Inactive
11 Rejected
10 Inactive
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. For extension settings you should use `this.getSettings()` from the entry point (line 146 `extesnion.js`). 4. Remove line 155-171 since you already have `this.getSettings()` in the entry point. 5. You shouldn't manage other extensions (line 51 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
melomane13 posted a review
about: You shouldn't manage other extensions (line 51 `extension.js`). * This method is used by other extensions, available on GNOME Extensions, * that manage the shell theme (e.g., AccentColorUserThemeExtension), thus * automatically applying a shell theme. * * We therefore believe we can do the same, despite the recommendation * "You shouldn't manage other extensions": * * 1. Without User Theme, we would have to reimplement its code in our extension * and add a UI for selecting themes. This already exists in some extensions * (e.g., User Theme X) and would go against the core idea of our extension. * * 2. Our approach ensures a **transparent user experience**: * - The user continues to use their usual settings (GTK, icons, cursor, accent-color) * without needing to open an additional interface. * - When the user switches from light mode to dark mode (or vice versa), * our extension automatically applies the stored themes without intervention. * - If User Theme is not installed, only the standard settings are applied, * ensuring compatibility and safety. */