Review of "Privacy Indicators Accent Color" version 6

Details Page Preview

Apply the system accent color to privacy indicators (e.g., microphone) and screen sharing/recording indicators, with an optional blurred background, in the top bar

Extension Homepage
https://gitlab.com/Sophtli/gnome-privacy-indicators-accent-color

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. What's the reason for importing `stylesheet.css` in dark and light stylesheet? Isn't it already imported when the extension is loaded? 2. If you want to hold settings in the property (line 6 `prefs.js`), you need to cleanup on window close request: ```js window.connect('close-request', () => { this._settings = null; }); ```
Sophtli posted a review
1. In my testing, it was necessary to import 'stylesheet.css'. Apparently, only either of the -dark and -light variants is being used when both of these files exist, otherwise, if one or both of the two files is missing, only stylesheet.css is being used. 2. Thanks, I'll add that! I followed this guide for my typescript migration: https://gjs.guide/extensions/development/typescript.html#prefs-ts Not sure who is responsible for it's contents but if you do know, they probably should add the cleanup there as well.