Show icon and label for panel Activities.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 31 | Active |
| 30 | Rejected |
| 29 | Active |
| 28 | Rejected |
| 27 | Active |
| 26 | Active |
| 25 | Active |
| 24 | Rejected |
| 23 | Inactive |
| 22 | Inactive |
| 21 | Inactive |
| 20 | Inactive |
| 19 | Inactive |
| 18 | Active |
| 17 | Active |
| 16 | Active |
| 15 | Inactive |
| 14 | Inactive |
| 13 | Rejected |
| 12 | Active |
| 11 | Active |
| 10 | Active |
| 9 | Active |
| 8 | Inactive |
| 7 | Active |
| 6 | Rejected |
| 5 | Active |
| 4 | Rejected |
| 3 | Active |
| 2 | Active |
| 1 | Inactive |
Sending `this.settings` to `destroy()` is a bad practice. You should hold the settings in `ActivitiesIndicator._settings` and use it inside `destroy()`. Wanna fix and send it again?
Thank you for your review and your daily reviews. I'd like to ask if this.disconnect(this._settingsID); is correct.
The idea is to do this: ```js class ActivitiesIndicator extends PanelMenu.Button { _init(settings) { super._init(0.5, 'Logo Activities', true); this._settings = settings; ``` Now, change line 461 `extension.js` to: ```js this._settings.disconnect(this._settingID); ```
Thank you so much. I'll upload the fixed one.