Review of "Prayer Times" version 2

Details Page Preview

Highly customizable and efficient prayer time and athan reminder extension for Gnome. Features: Location: auto detection and custom parameters Calculations: - Preset and custom Fajr & Isha angles - Asr shadow lengths - High latitude Fajr and Isha correction (1/2 of night, 1/7th of night, and angle based) - Optionally include sunnah prayers (Duha) Notifications: - Send notifications for prayers - Play a shorter version of an athan for prayers - Reminders before prayer time Display: - Automatic clock format detection - Highlight next prayer in menu Translations: Arabic

Extension Homepage
https://github.com/Mocab/Prayer-times-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Better to use `this.path` instead (line 93 `extension.js`). 2. Please don't store any instance of objects in a property in the default class you are exporting (line 6-7 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make them local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
mocab posted a review
Thank you very much for your review!