Review of "No Screenshot Box" version 1

Details Page Preview

Customizes the GNOME screenshot UI with an empty initial selection, optional capture on release, and an independent screenshot sound mute.

Extension Homepage
https://github.com/abdallah-alkanani/no-screenshot-box

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
6 Active
5 Rejected
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please move line 239 `extension.js` to enable and null it out in disable: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Why are you trying to find the `_areaSelector` in line 141-166 `extension.js`? Shouldn't the `_areaSelector` holding the `AreaSelector`? 4. No need using `=== 'function'` in anywhere in this code. 5. try-catch wrapper isn't needed for disconnect (line 100 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions