Review of "Essential Tweaks" version 3

Details Page Preview

Tweak annoying defaults and enable quality of life features

Extension Homepage
https://github.com/lublst/gnome-essential-tweaks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
In all of the modules inside `lib` folder, you are using `this.`. There isn't any class there. They are normal functions and obviously this package won't work just because of that.
Lukas Bleisteiner posted a review
I will change the modules to use proper classes in a later release. Currently I am binding `this` in `extension.js:19`: ``` this._modules = [ ['click-to-close-overview', updateClickToCloseOverview.bind(this), disableClickToCloseOverview.bind(this)], ... ]; ``` I obviously tested the extension before uploading it.
JustPerfection posted a review
You shouldn't do that. It makes the code unreadable.