Review of "Lock Guard" version 1

Details Page Preview

Hide date and quick settings on lock screen for enhanced security and privacy.

Extension Homepage
https://github.com/fthx/lock-guard

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

fthx posted a review
Hi JP, I think I need here your auth to not disable the extension? And is this the correct way you expect?
JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 2. Move line 11 to enable and disconnect object on disable.
fthx posted a review
But it will not work if I do so, isn't it? Ok for github.
JustPerfection posted a review
Your extension should clean up properly on disable. Currently works because you are not cleaning up and extension leaves its code after disable. On lock, extensions get disabled if they don't have the unlock session permission. Even those with permission may get disabled and re-enabled since that's how re-basing works. So, if your extension only needs to work on lock screen, add this to the `metadata.json`: ```json "session-modes": ["unlock-dialog"] ``` You can read about the [session modes in the docs](https://gjs.guide/extensions/topics/session-modes.html). Also read the [review guidelines for session modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes).