Review of "Gnome Routines" version 2

Details Page Preview

If/then condition-based automation for GNOME. Create routines to automatically trigger actions based on time, battery, network, apps, and more. This extension can read and write to your clipboard when using clipboard triggers or actions.

Extension Homepage
https://github.com/supSugam/gnome-routines

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use prettier to have empty lines between functions and before class definitions. 2. Please add to the description that this extension is using clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 4. Timeout should be removed on disable/destroy and before creating a new one: - line 7 `engine/actions/connection.js` - line 1397, 1446 `gnome/adapters/gnomeShellAdapter.js` - line 44 `engine/actions/volume.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 5. Use [`getMixerControl()`](https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/0eb754a08421250856cff81219d75ce0396bafba/js/ui/status/volume.js#L22) or d-bus instead of subprocess. All subprocesses and spawn commands should be removed from: - `gnome/adapters/gnomeShellAdapter.js` - line 54 `ui/features/bluetooth/connectBluetoothActionEditor.js` - line 54 `ui/features/bluetooth/disconnectBluetoothActionEditor.js` - line 52 `ui/features/bluetooth/triggerEditor.js` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions