1. Bad schema path in the XML file [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 2. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Please remove the timeout before creating a new one since that function can be called multiple times (line 121 `extension.js`). 5. Don't use old imports (line 10 `classes/musicPlayer.js`). 6. That will break the GNOME Shell if happen for the second time (line 11 `classes/musicPlayer.js`). Remove that line and do this inside `MusicPlayer._initPlayer()` instead: ```js if (!Gst.is_initialized()) { Gst.init(null); } ``` 7. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 8. Add to the description that this extension is usind zenity as its dependency. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions