Review of "Battery Power Monitor [Percentage, Time Remaining and Watts]" version 4

Details Page Preview

Battery Power Monitor - Shows percentage, time remaining, and watts in the GNOME Shell panel. Real-time power consumption monitoring with smart display options.

Extension Homepage
https://github.com/DarkPhilosophy/batt-watt-power-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 (5) Unreviewed
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `screenshot.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Remove `type` from `metadata.json`. 3. You already have `this.path` in the entry point. Use that instead (line 13 `prefs.js`). Anyway, I recommend to remove those lines and `build_date.txt`. Those are unnecessary and if you want to have your own version naming just simply use: [Extension Guide: `version-name`](https://gjs.guide/extensions/overview/anatomy.html#version-name) 4. Fix indentation (line 165 `prefs.js`). 5. Unused import (line 10 `extension.js`). 6. Null out in disable (line 16 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 7. Please use aysnc for reading file content since you are in shell process (line 23 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 8. Remove unnecessary try-catch wrappers (line 88, 140, 322 `extension.js`). 9. Replace line 322-328 `extension` with: ```js panel.statusArea.quickSettings._system._systemItem?.powerToggle?._sync(); ``` 10. Logs should be only available on debug mode: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions