Review of "Smart Home" version 19

Details Page Preview

With this extension, you can control miscellaneous smart devices on your local network: * Home Assistant (lights, plugs, covers, scenes) * Philips Hue (Bridge, Syncbox, sync screen, sync music) * Nanoleaf devices (lights, scenes, sync screen) * Ikea Dirigera (lights, plugs, covers) * Shelly devices (lights, plugs, covers) Please, report issues or bugs on GitHub.

Extension Homepage
https://github.com/vchlum/smart-home

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Where `avahi.js` is getting loaded? In`extension.js` process?
JustPerfection posted a review
Didn't `GLib.find_program_in_path()` work for this? ```js export function isAvahiBrowseInstalled() { return GLib.find_program_in_path('avahi-browse') !== null; } ```
chlumskyvaclav posted a review
avahi.js is imported in api.js for most of the plugins, this files are used in both extension.js and prefs. The actual avahi-browse is really used only in prefs.
chlumskyvaclav posted a review
Yes, `GLib.find_program_in_path()` is much better. I will change it. Thx.
JustPerfection rejected
Ok. Please send the fix. You cannot use sync spawn in the shell process since that can freeze the shell.