Review of "Keyboard Layout Flags" version 2

Details Page Preview

Adds Unicode country flags next to layout names in the keyboard switcher (Super+Space)

Extension Homepage
https://github.com/buengenio/keyboard-layout-flags

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

buengenio posted a review
Thanks for doing this during public holiday! Merry Christmas, in case you celebrate! I did use a bit of GPT to figure out how to access the OSD labels - it's my first extension and I've been struggling to figure out which API to use on gjs-docs. The emoji/locale code came pretty much verbatim from a 10 year old web project. - metadata updated, thanks for RTFM - try/catch left over from debugging removed as Gnome does the logging anyway.
JustPerfection posted a review
Thanks! 1. Please remove `icon.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Timeout should be removed on disable (line 66 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
JustPerfection rejected
JustPerfection posted a review
Also, Happy Holidays and Merry Christmas!