Review of "Rabbit Forex" version 1.0.0 (1)

Details Page Preview

Monitor exchange rates for fiat currencies, precious metals, cryptocurrencies and stocks. Click on any rate to copy it to clipboard.

Extension Homepage
https://github.com/Rabbit-Company/RabbitForexAPI

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.7.0 (8) Active
1.6.0 (7) Active
1.5.0 (6) Rejected
1.4.0 (5) Active
1.3.0 (4) Active
1.2.0 (3) Active
1.1.0 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 3. Remove `session-modes`: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 4. Remove version form the imports: - line 4 `extension.js` - line 5 `prefs.js` 5. You should call `abort()` on destroy (line 30 `extension.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 6. Bad practice (line 389 `extension.js`). Your extension is either destroyed or not. 7. Avoid unnecessary logs. 8. Please follow our rules for clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 9. Instead of wrapping the `get_strv()` with try-catch which `get_strv()` never throws, you should use a helper function like this to avoid using wrong keys instead: ```js const WATCHED_CATEGORIES = ['fiat', 'metals', 'crypto', 'stocks']; #getWatchedCategoryValue(category) { if (!WATCHED_CATEGORIES.includes(category)) return []; return this._settings.get_strv(`watched-${category}`) ?? []; } ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions