Review of "Desktop Widgets" version 1

Details Page Preview

A modular widget system for your desktop. Place and customize various widgets on your background to enhance your workspace. Extension Homepage: https://github.com/NiffirgkcaJ/desktop-widgets https://gitlab.com/NiffirgkcaJ/desktop-widgets

Extension Homepage
https://github.com/NiffirgkcaJ/desktop-widgets

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't put git urls into the description. 2. Also destroy and null out in disable: ```js this._configManager?.destroy(); this._configManager = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Always better to create destroy function instead of registering the signal (line 46 `plugins/datetime/widget.js`): ```js destroy() { if (this._timeoutId) { GLib.source_remove(this._timeoutId); this._timeoutId = null; } super.destroy(); } ``` 4. Use the import at top of the class (line 143 `shared/services/servicePluginRegistry.js`). 5. I recommend to move these file to a more obvious folder so it obvious that they are only used in `prefs.js` process: - `shared/components/componentProfileRow.js` - `shared/utilities/utilityIconGtk.js`