Review of "GSpotify & Downloader" version 17

Details Page Preview

A label, downloader and integrated Spotify controller for GNOME Shell. Uses system clipboard for menu actions. Uses spotdl for downloads. This extension is not affiliated, funded, or in any way associated with Spotify.

Extension Homepage
https://github.com/sxoxgxi/gspotify

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
19 Unreviewed
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Inactive
9 Active
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version form the import: - line 3 `spotify-auth.js` - line 1 `spotify-helper.js` 2. You should call `abort()` on disable or destroy: - line 103, 316 `spotify-auth.js` - line 11, 38, 67, 106 `spotify-helper.js` [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 3. You cannot create instance of objects in global scope (line 198 `spotify-auth.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Is client id usage in line 11 `constants.js` intentional? Is that a public id?