Review of "HakaWaka" version 1

Details Page Preview

See all your Wakatime, Wakapi and Hakatime statistics in your panel It connects with either the official instances or with self hosted ones.

Extension Homepage
https://github.com/Topvennie/hakawaka

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Please don't store any instance of objects in a property in the default class you are exporting (line 10 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Better to attach settings to the `window._settings` as described in the docs: [Extensions Guide: prefs](https://gjs.guide/extensions/development/preferences.html#prefs-js) If you don't want to do that, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 3. Use prettier to have empty new lines between classes and functions. 4. Add to the description that this extension uses `wakapi.dev`, `wakatime.com` and `hackatime.hackclub.com` services. 5. You should call `abort()` on disable or destroy (line 21 `extension/hakawaka.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions