A Simple Bengali Calendar Extension for Gnome Shell
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 4 | Unreviewed |
| 3 | Active |
| 2 | Rejected |
| 1 | Rejected |
1. Please remove `icon` from `metadata.json`. Not needed. 2. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Please remove unnecessary try-catch wrappers. AFAICS, all of them are unnecessary. Especially, you are wrapping enable and disable in try-catch and re-throw error on catch which is anti-pattern. 4. Creating the default class you are exporting in `extension.js` that large is prone to bad cleanup. It is also hard to review. I recommend to move them to another class(es) and keep the default class less than 100 lines. 5. Removing the timeout first thing in disable is a good idea to avoid racy situations. 6. Instead of connect (line 80-141 `extension.js`), you can use `this._settings.connectObject('signal', () => {}, this)` and then simply do `disconnectObject(this)` on disable. That's easier to handle. Note: `connectObject()` works for all clutter actors. 7. Please remove: - `icon.svg` - `icon-symbolic.svg` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions REVIEWERS NOTE: Didn't check the `extension.js` full for cleanup since the default class needs to be fully modified for the next version.