Review of "Keyboard Backlight Idle Timeout" version 2

Details Page Preview

Turn off keyboard backlight after idle timeout and restore previous level on activity (via SettingsDaemon Power Keyboard).

Extension Homepage
https://github.com/gonemooncool/keyboard-backlight-timeout

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `locale` folder since it is empty. 2. Remove version from the import (line 3 `prefs.js`). 3. No need to use `this.initTranslation()` (line 25 `prefs.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 4. Please remove line 79-83 `prefs.js`. Unnecessary to track window close.