Review of "P7 Commands" version 8

Details Page Preview

Sensible commands like window auto resize, mouse move resize, etc

Extension Homepage
https://github.com/prasannavl/p7-cmds-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Prasanna Loganathar auto- rejected
Auto-rejected because of new version 9 was uploaded
JustPerfection rejected
1. There are many unnecessary lines in `prefs.js`. 2. Remove line 42 `keybindmanager.js`. That falls under selective disable. 3. Anyway, If your extension is created to modify the shortcuts, it shouldn't be an extension in the first place. It should be a bash script. You shouldn't change the user shortcuts (`keybindmanager.js`). That can be risky even when you have the restore logic.
Prasanna Loganathar posted a review
Thanks for the review. Apologies about the multiple versions before coming back to this. Uploaded version 11 addressing the above. 1. Could you please let me know what is unnecessary? They are correspond to the settings and I don't see any duplication or things I wouldn't want to configure as a user myself. 2. Resolved. 3. Resolved. It now has a "override and restore" as config, which can only be turned on intentionally by the user, otherwise, if it detects conflicts it simply warns without overriding. > it shouldn't be an extension in the first place This is an extension, since I do have other commands related to tiling that requires mutter APIs. I get that the current set can be done with scripts, but it has all the plumbings, and is just the initial set, but still useful by itself at the moment without the other commands. Hope that helps with context.