Review of "Net Speed Plus" version 1

Details Page Preview

Display real-time network download and upload speed in the top panel

Extension Homepage
https://github.com/shivamksharma/gnome-shell-extension-net-speed

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. No need to use any parameters for `getSettings()` since you already have the value in `metadata.json`. 2. Don't use sync spawn since that can freeze the shell process (line 133 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 3. Please don't use deprecated modules (line 138 `extension.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 4. Please use aysnc for reading file content since you are in shell process (line 189 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 5. Please use a different name for your extension since we already have that name: [Net Speed Extension](https://extensions.gnome.org/extension/4478/net-speed/) No need to change the uuid. Just change the name, schema id and path. I highly recommend to move to the 45+ and avoid older versions for new a extension, since that would be hard to maintain in the future. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions