Review of "Window Resizer" version 1

Details Page Preview

Resize the focused window to predefined sizes using keyboard shortcuts. Cycle through sizes or jump directly to specific presets.

Extension Homepage
https://github.com/JavierMonton/gnome-window-resizer

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Please remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 4. Please don't store any instance of objects in a property in the default class you are exporting (`prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Either move everything out of the default class or you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JavierMonton posted a review
Hello, Thanks for the review and the explanations. I have uploaded a new version addressing those comments. I hope it's better now.